simon360 / react-from-markup

Declare your React components with static HTML
MIT License
18 stars 4 forks source link

fix: empty style tag no longer throws error #34

Closed willtonkin closed 5 years ago

willtonkin commented 5 years ago

if <p style="" /> were to be parsed this invalid style prop would reach React and an error would be thrown, stopping rehydration

willtonkin commented 5 years ago
willtonkin commented 5 years ago

For some more context, I wrote a test here, specifically here that this PR should resolve.

There's additional changes as well that I was looking at in that branch, which may or may not be useful :)

willtonkin commented 5 years ago

35 will need to be resolved first before CI will pass

simon360 commented 5 years ago

You're doing the Lord's work, @willtonkin. May all devs bow down before you.

(Should work on a rebase)

willtonkin commented 5 years ago

Rebased, back to you @simon360 if you'd like to merge