simonallfrey / programmingPhoenixLiveviewSlime

0 stars 0 forks source link

Help with adding sigil support and merging #1

Open tensiondriven opened 1 year ago

tensiondriven commented 1 year ago

Hi Simon,

I saw you forked my repo for Phoenix Slime (and possibly Slime). You're right, my efforts stalled after I got a working implementation and I haven't had time/energy to follow up to get it merged back in. I also saw that you added sigil support, which I have very much been wanting!

Are you interested in working together on the pull request to get phoenix slime updated to support latest phoenix/liveview and with sigil support?

simonallfrey commented 1 year ago

Hi Jonathan,

Great to hear from you.

It was https://github.com/thepeoplesbourgeois/phoenix_slime who added sigil support, not me!

You merged it in here: https://github.com/tensiondriven/phoenix_slime/pull/1/commits

thepeoplesbourgeois has also added some code generation tasks.

I'm not sure what needs doing to get the PR accepted, it seemed to me that it was missing a review from doomspork or another slime-lang contributor.

I've got a little time, but realistically I think we'd need to get thepeoplesbourgeois onboard to get this done.

Best regards,

Simon.

On Tue, 29 Nov 2022 at 18:53, Jonathan Yankovich @.***> wrote:

Hi Simon,

I saw you forked my repo for Phoenix Slime (and possibly Slime). You're right, my efforts stalled after I got a working implementation and I haven't had time/energy to follow up to get it merged back in. I also saw that you added sigil support, which I have very much been wanting!

Are you interested in working together on the pull request to get phoenix slime updated to support latest phoenix/liveview and with sigil support?

— Reply to this email directly, view it on GitHub https://github.com/simonallfrey/programmingPhoenixLiveviewSlime/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRD6F7D67ZVK3LHXXXEB43WKY7INANCNFSM6AAAAAASOYHWGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Dr S. J. Allfrey @.*** +33 (0)6 79 65 29 98 Skype: simonjallfrey