simonarvin / eyeloop

EyeLoop is a Python 3-based eye-tracker tailored specifically to dynamic, closed-loop experiments on consumer-grade hardware.
GNU General Public License v3.0
479 stars 68 forks source link

Error while running plot_loop.py #30

Closed raghavprasad13 closed 3 years ago

raghavprasad13 commented 3 years ago

I'm encountering an error when I try to run plot_loop.py in the open_loop example. Initially, I got this error. I temporarily solved it by hardcoding self.animal = "mouse" in the Loop_parser constructor. However, after that, I faced another error. I'm not sure how to fix this.

P.S. I used the open-loop-log.json file.

P.P.S Is there any documentation regarding the keys in the JSON log file and what they represent?

kinow commented 3 years ago

I've reproduced the issue. Looks like the plot example extends the Parser class, which requires an animal parameter. If the plot example class calls the Parser constructor, that should fix the error. But after that locally, I found a few more errors.

Trying to prepare a PR with what I've found, but as I don't know much about the JSON log file or the example code, it would need some review from @simonarvin or someone else :+1:

simonarvin commented 3 years ago

Hi @raghavprasad13

This error was caused by a legacy/modern format mismatch. This has been fixed in edad0fe2352a0bc2777554062aa7685a301083fb

Thanks for reporting it!

Best, Simon

simonarvin commented 3 years ago

Hi @raghavprasad13

I suspect you're loading the wrong log file (legacy format). Can you try again, making sure to load the new, re-formatted log?

Best, Simon

raghavprasad13 commented 3 years ago

Yes @simonarvin I apologize 🙈 That was my mistake Thank you very much for fixing this issue!