search

simonbengtsson / eventcal

Filter to only include attending and maybe facebook events in ical and google calendar
http://eventcal.flown.io
MIT License
211 stars 8 forks source link

improvements needed #17

Closed nolybom closed 7 years ago

nolybom commented 7 years ago

Aloha, quite happy that i found your script here. Thank you! I was actually dealing with some other scripts but yours seams quite reliable. Discovered a small bug though.

Button of the System Calendar should'nt open a new tab, so in line 119 you could do this:

window.open(url,"_self");

Then in line 149 we have:

var base = 'webcal://' + window.location.host + '?base64=true&calendar=';

Unfortunately that restricts eventcal to the root. If eventcal is placed in a directory the generated webcal-link is invalid.

Do you have an idea how we could integrate events of a public fanpage and limit it it to get only upcoming events? The Graph would look like this:

https://graph.facebook.com/v2.9/17168992485/events?time_filter=upcoming&access_token=xxxyyyzzz

Of course a access_token is needed.

simonbengtsson commented 7 years ago

Sounds like great changes, feel free sending a pull request! I'm not very familiar with the graph api so can't help you there I'm afraid.

Cheers!

simonbengtsson commented 7 years ago

As you pointed out, you would probably need to use the graph api etc so that service would probably have very little in common in terms of code with this one. It's an interesting idea and if I ever find the need myself I might do it. Let me know if you end up implementing it.