search

simonbengtsson / eventcal

Filter to only include attending and maybe facebook events in ical and google calendar
http://eventcal.flown.io
MIT License
211 stars 8 forks source link

only subset of interested/going events showing up #32

Closed chinarut closed 4 years ago

chinarut commented 4 years ago

hi! first I want to say THANK YOU for EventCal - this tool is a godsend ever since Sunrise.am hit the fan! and double thanks for open sourcing it, I had no idea til today so it's awesome you have a form of community support here :)

My feed has been perfect thru 2019 & suddenly random "interested" events no longer show up in Google Calendar (where I've subscribed).

I've refreshed my feed in Google Calendar (Pixel 3a, Android 10), new events will show up in the feed (missing ones don't show up) & wondering how we can go about troubleshooting this issue?

Let me know how I can help :)

simonbengtsson commented 4 years ago

Thanks for the kind words!

I would double check that the file from Facebook contains the missing events. If it does we know it is an issue with this service 👌

chinarut commented 4 years ago

ok I have my Facebook Event feed URL. if I open it, it produces an ICS file. I'm a newbie navigating these data structures & don't understand if it is a pointer to events or actually contains events.

What tool do I use to inspect my Facebook calendar feed without importing it into Google Calendar?

simonbengtsson commented 4 years ago

One way is to:

  1. Rename to a *.txt file u1605651051.ics ➡ u1605651051.txt
  2. Double click the file
  3. Scan the file for the event name you are missing

Or you can right click the ics file and open it with either Notepad or TextEdit depending on if you are on mac or pc.

chinarut commented 4 years ago

thanks for the guidance.

So I've verified the ICS contains the missing events and I haven't updated or regenerated my feed on EventCal for over a year (it just stopped working)

An example event that does not show up: All that Jazz (Feb 7-10)

this event has a field "PARTSTAT:TENTATIVE"

I looked at your code and it seems like Facebook might have changed it from STATUS_MAYBE to TENTATIVE on us

think this is it?

ps. I don't see a way to attach the ICS file to this post in the GitHub mobile web UI in case you want to see it

simonbengtsson commented 4 years ago

It seems old calendar urls have expired by facebook and you need to generate a new one. Can you verify it works after adding the new calendar?

simonbengtsson commented 4 years ago

If that doesn't work it would be very helpful if you could attach the ics file! I tested with my facebook events now and when I mark an event as "interested in" it is showing up as it should in Google Calendar. There is someone on twitter who reported that he didn't get "maybe" events synced either so it might be some issue here.

chinarut commented 4 years ago

ok good news - recreating the feed works. it shows up on my web calendar & just waiting for it to show up in my Google Calendar app (used refresh but it lags)

I also noticed the ICS file now contains just my interested & going events. I dont believe this was configurable on the Facebook end.

I tested adding the Facebook URL directly & they are now the same.

I dont know if Facebook got to its senses and cleaned up their feed?

Ill leave both the original & EventCal feeds subscribed on my dev device. Ill let you know if i ever see any deviation.

Thank you for all your help! its interesting to see PHP do PERL like stuff in the web world :)

chinarut commented 4 years ago

hey hate to reopen this issue - I had to move my Facebook calendar from gmail to a G Suite account and can't make rhyme or reason why both feeds are different:

Facebook vs eventcal in Google Calendar

first, i just added these in the last 24 hrs (Facebook URL to my calendar last night - purple) and eventcal just 30 minutes ago (blue) so they are both recent.

second, I'm not clear why both feeds don't match - adding the Facebook Updates URL (purple) directly is more complete.

third, I find it curious the multi-day "Kindred Spirit" is picked up by eventcal but it's not in the ICS

even though the event is canceled, I feel eventcal does has the correct behavior to display this event (but missing 5 other events...)

The ICS file: https://pastebin.com/X2G9Nknu

for clarity:

ckrf commented 4 years ago

I also have some Maybe/Interested events which are not showing up and some that are showing up.

I thought it might be recurring events that don't show up, but here's a non-recurring event that doesn't show up:

ICS file: https://pastebin.com/FMBEbKY1

simonbengtsson commented 4 years ago

Thanks for the example events! Will take a look. Added myself as interested for the event you linked for easier debugging (hope that is fine)...

ckrf commented 4 years ago

Absolutely fine! Thanks so much for the immediate response.

mpesavento commented 4 years ago

Same problems as above. I can't seem to find a pattern for why some appear and others don't. Also thought that it may be related to recurring events, but am able to see some recurring events, and not see one-time events. This is a little frustrating, as this amazing service has been so reliable. Alas, such is the pain of updating JSON parsers. Thank you for this project!

quintrino commented 4 years ago

Also having some issues, I haven't done a full investigation, but the event that's not showing for me is a recurring event, so I'm not sure if that would be influencing things at all.

quintrino commented 4 years ago

Sample event is https://www.facebook.com/events/237275494053213/ Also, I generated a new URL and selected attending/interested AND needs action and it still doesn't show if that helps narrow it down.

simonbengtsson commented 4 years ago

Something interesting I found now is that it seems it is showing up in for example the built in mac calendar. But not showing in Google Calendar. Is this something you can replicate as well?

quintrino commented 4 years ago

Tested it now and you're right. It shows on the Mac Calendar app, but not on Google Calendar.

I also strangely noticed that my original Facebook feed for some reason includes a duplication for the event I first noticed it on.

Once was https://www.facebook.com/events/237275494053213/ and the other https://www.facebook.com/events/237275494053213/?event_time_id=237275497386546

Not sure if that helps at all.

simonbengtsson commented 4 years ago

Noticed the same thing with the duplicate!

Actually found an error now that might fix this issue as well. It seems to fix both of the events reported her at least. It should work whenever google decides to sync the next time for existing calendars, but to force a refresh can you try if readding the calendar and see if the event shows up correctly?

quintrino commented 4 years ago

Took me a second that you didn't mean reading and and instead meant re-adding. :P

Unfortunately re-adding it didn't seem to work, but I suspect it's just retaining a cache of when I originally added it (given it keeps the same name and colour preference)

I temporarily added my feed to a different Google calendar account and it's now showing the events correctly again. I'll just have to wait for Google to update my actual Calendar account.

What bug did you find? Seems like it's fixed the issue.

simonbengtsson commented 4 years ago

Oops! A trick I've used to avoid caching is to append a query param to the end of the link such as "&foo=bar". I updated some file permissions on the server a while back which generated a php warning making the ics file invalid. I'm surprised it worked at all before to be honest ^^

ckrf commented 4 years ago

I re-added with a bogus query param but it's still not working for me, e.g., on https://www.facebook.com/events/693270884548721/ and https://www.facebook.com/events/571492766800072/

On Fri, Apr 17, 2020 at 1:22 PM Simon Bengtsson notifications@github.com wrote:

Oops! A trick I've used to avoid caching is to append a query param to the end of the link such as "&foo=bar". I updated some file permissions on the server a while back which generated a php warning making the ics file invalid. I'm surprised it worked at all before to be honest ^^

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/simonbengtsson/eventcal/issues/32#issuecomment-615100682, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHMJWGMFYY7DMYTQRAZPULRNADETANCNFSM4KQROMVQ .

-- I check this mailbox once per day. If time sensitive, please text me.

simonbengtsson commented 4 years ago

Those events are working for me. Which calendar client are you using @ckrf?

ckrf commented 4 years ago

Google Calendar in Chrome. Any logs or anything I can share to help debug?

ckrf commented 4 years ago

It's working now! Thank you!

I deleted the calendars and resubscribed using the "System Calendar" link (which still took me to Google Calendar, I guess because that's how my Chrome is set up). It started working. 🤷‍♂️

simonbengtsson commented 4 years ago

Weird! But great! 🎉

chinarut commented 4 years ago

thanks for the extra input everyone - I've been monitoring the official Facebook feed, EventCal, and another implementation I found and all feeds have been consistent since the last blip I reported above 3 weeks ago.

It seems whatever needed to be ironed out has been ironed out so going to close this issue!