simonbengtsson / jsPDF-AutoTable

jsPDF plugin for generating PDF tables with javascript

https://simonbengtsson.github.io/jsPDF-AutoTable/

MIT License

2.33k stars 624 forks source link

Fix rowspan cross multi pages #1031

Open trung37 opened 9 months ago

trung37 commented 9 months ago

809

simonbengtsson commented 9 months ago

Looks like a great fix! Could you describe your pull request a bit and clean up the title? Also would be great to update the pull request to not include dist files, complexdata.js or font file in addition to run prettier code formatting on the changes.

trung37 commented 9 months ago

I added function named "splitRowSpan", consider the row, that had rowspan I calculated current row height, if it 's height over the avaiable space, I clone the rowspan cell to next rows, and reduce the cell height, ultil number of rows fit to the rowspan cell keepPage: ensure not break page process by shouldPrintOnCurrentPage function isBreakPage: ensure break page on the row should be break page

simonbengtsson commented 2 months ago

Thougths on merging this @mmghv ?

mmghv commented 2 months ago

@simonbengtsson Give me some time I'll have a look at it and see how does it relate to the work I've been doing on v4 regarding spans.

zhouzhi-zz commented 2 months ago

@simonbengtsson Give me some time I'll have a look at it and see how does it relate to the work I've been doing on v4 regarding spans.给我一些时间，我会看一下它，看看它与我在 v4 上所做的关于 span 的工作有什么关系。

When is the v4 expected to be released， thanks.

mmghv commented 2 months ago

When is the v4 expected to be released， thanks.

No dates yet.