simonbs / SBSAnimoji

🐵 Animoji app using Apples AvatarKit
1k stars 103 forks source link

Adds karaoke #19

Closed simonbs closed 2 years ago

simonbs commented 7 years ago

This is a rough implementation of recording Animoji karaoke videos. There are still some issues with the implementation. Since my iPhone X is currently being replaced by Apple I'm unable to investigate these issues further until I receive a replacement device.

The feature was put together as part of a hackathon and has its rough edges which is why it is not yet merged into the master branch.

Pessing "Start karaoke" starts a flow for searching and picking a video from YouTube. When a video is picked, it can be played and users can bbe the desired time of the video to start their recording at.

Pressing record will then play the video while recording. When exporting the Animoji video, the audio from the original Animoji video is removed and replaced with the audio from the YouTube video.

screenshot

psppro26 commented 7 years ago

Very nice dude !

psppro26 commented 7 years ago

I installed this on my phone but i see no change and there is no karaoke button ?

simonbs commented 7 years ago

@psppro26 Ah, right. You'll need to follow Googles guide on obtaining a YouTube API key and set it as the value for SBSYouTubeAPIKey in the Info.plist.

psppro26 commented 7 years ago

@simonbs just did working great ! good work bro <3

psppro26 commented 7 years ago

just found some bug :

psppro26 commented 7 years ago

and just asking , dont know if its possible : there is a way to send that karaoke not in video in messages but like in real animoji like apple ? cause its so much smoother , and animoji play without need to launch the video etc

soh20 commented 7 years ago

Hi @simonbs i tried to add the value for the youtube karaoke but i dont see the button. i downloaded the version which was recently updated 7 days ago. Or do i have to use a new one?

simonbs commented 7 years ago

@soh20 You need to use the feature/karaoke branch.

soh20 commented 7 years ago

Thanks for the fast reply. Now with this version i get this error even though the files are there:

/Users/soh20/Library/Developer/Xcode/DerivedData/SBSAnimoji-crpdlkbafsthiygizkbntydqbiyp/Build/Intermediates.noindex/SBSAnimoji.build/Debug-iphoneos/SBSAnimoji.build/Script-72AD797A1FB4BA7C004D234F.sh: line 2: /usr/local/bin/carthage: No such file or directory

simonbs commented 7 years ago

@soh20 Sounds like you didn't install Carthage.

soh20 commented 7 years ago

WORKS now. thanks a lot mate. :)