use environment vars, not globals

simonbyrne / MathLink-old.jl

Mathematica interface for Julia

Other

5 stars 0 forks source link

use environment vars, not globals #1

Open stevengj opened 9 years ago

stevengj commented 9 years ago

The README file says that MATHLINK_LIB is an "environment variable", but it is actually read via @getoption as a global variable.

I would recommend just using an environment variable, as documented. Then you can use get(ENV, "MATHLINK_LIB", ...some default...) to get the value, rather than writing a macro.

simonbyrne commented 9 years ago

It could also be done in a deps/build.jl file.

stevengj commented 9 years ago

Yes, see #2.