search

simoncchu / smhasher

Automatically exported from code.google.com/p/smhasher
3 stars 0 forks source link

Patch for /trunk/MurmurHash3.cpp #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Replace inline by FORCE_INLINE in rotl*

Original issue reported on code.google.com by gafunc...@gmail.com on 23 Apr 2012 at 4:52

Attachments:

GoogleCodeExporter commented 9 years ago 
"always_inline" only works for GCC, and in general if your compiler isn't 
obeying the 'inline' keyword then that's a bug in the compiler and not the code.

Original comment by tanj...@gmail.com on 11 May 2012 at 6:12

GoogleCodeExporter commented 9 years ago 
Your argument is invalid, because you are already using always_inline in this 
function:

FORCE_INLINE uint32_t getblock ( const uint32_t * p, int i )

So there is an inconsistency in the usage of always_inline/inline/FORCE_INLINE 
and that is a bug in the code, regardless of the compiler.

Original comment by gafunc...@gmail.com on 11 May 2012 at 10:15