search

simonclausen / dnscrypt-autoinstall

Automatic installation and configuration of DNSCrypt (on Debian + Redhat like systems). This script will install DNSCrypt and configure it to start on boot and use an optional dnscrypt service.
Other
224 stars 73 forks source link

url wrong #24

Closed 6api closed 8 years ago

6api commented 10 years ago

please check it! and use wget better and check download status

AladW commented 10 years ago

Wget was changed to curl because of certificate errors (#4). The URL is not wrong - it was changed to github because the regular source works unreliably (#23). A status check would be good, though.

simonclausen commented 10 years ago

As Alad points out the URL is correct. The status check is a good idea though.

I'll leave this open for now.

6api commented 10 years ago

it is wrong $LSODIUMURL/libsodium-$LSODIUMVER.tar.gz == https://github.com/jedisct1/libsodium/archive/0.6.1.tar.gz/libsodium-0.6.1.tar.gz did you check it?

wrong https://github.com/jedisct1/libsodium/archive/0.6.1.tar.gz/libsodium-0.6.1.tar.gz correct https://github.com/jedisct1/libsodium/archive/0.6.1.tar.gz

6api commented 10 years ago

wget could use --no-check-certificate curl make download failed on some slow network

AladW commented 10 years ago

I'd rather have a failed download than an unverified download. However, you could do e.g curl --retry 5. Re links, I also noticed the github page doesn't have a signature - but it's probably better to download it from elsewhere anyway (or use a dig check). I'll make some changes, thanks. (and I'll make sure to test it this time :P )

AladW commented 10 years ago

Just needs the download check, then this can be closed.

AladW commented 8 years ago

The script in the fakeroot branch uses set -e, to directly abort on errors like this.