search

simoncozens / fontspector

Skrifa/Read-Fonts-based sketch for a font QA tool
Apache License 2.0
7 stars 1 forks source link

Split universal and opentype profiles? #14

Closed simoncozens closed 1 month ago

felipesanches commented 1 month ago

yes, please ;-)

felipesanches commented 1 month ago

@simoncozens, I'll prepare a PR for this one, ok?

simoncozens commented 1 month ago

Yes, sure. Thank you!

felipesanches commented 1 month ago

Also, please make the adjustments for me to be able to self-assign issues in this repo (or maybe we should migrate it to the fonttools org, just like fontbakery)

simoncozens commented 1 month ago

Maybe hold off on this for a moment. I think maybe one of the reasons why I merged universal and opentype profiles is because that split is not correct in fontbakery.

For example: opentype/name/italic_names looks at the filename to determine whether the font is Italic or Regular and checks the name table entries accordingly. That's not a matter for the OpenType standard; it's a Universal check, but fontbakery has it on the opentype profile.

felipesanches commented 1 month ago

well... then we rename that check to 'name/italic_names' and move it to Universal.