search

simondean / parallel-cucumber-js

Executes Cucumber scenarios in parrallel, reducing the amount of time tests take to execute
MIT License
19 stars 12 forks source link

Skip collecting tags from Background #20

Closed skadeglad closed 8 years ago

skadeglad commented 8 years ago

"Background" is also a child of Feature, but it does not have "tags" property, so self._collectTags end up with an error, while trying to get tags from it.

This simple 'if' statement solves the issue.

simondean commented 8 years ago

Thanks for the pull request @SkadeGlad. Would it be possible to add an acceptance test / functional test that covers the issue? They're under https://github.com/simondean/parallel-cucumber-js/tree/master/features

simondean commented 8 years ago

@SkadeGlad I've added a test for Backgrounds and merged into master. I'll do a release now. Thanks for the pull request

simondean commented 8 years ago

@SkadeGlad I've just pushed the fix as version 1.0.1: https://www.npmjs.com/package/parallel-cucumber