Renaming works for labels and symbols generally. However, if you do the Find All References command on a symbol/label and then try to rename it, then it fails due to 'duplicate edits'.
The bug is in the onReferences function, as get all the references and then push the location of the definition itself to the list for returning to VSCode. This mutates the list of references in the symbol table, eventually causing issues when the references should not include the definition itself.
Renaming works for labels and symbols generally. However, if you do the
Find All Referencescommand on a symbol/label and then try to rename it, then it fails due to 'duplicate edits'.The bug is in the
onReferencesfunction, as get all the references and then push the location of the definition itself to the list for returning to VSCode. This mutates the list of references in the symbol table, eventually causing issues when the references should not include the definition itself.