v2.1.0 release issues - Githubissues

simondotm / nx-firebase

Firebase plugin for Nx Monorepos

https://www.npmjs.com/package/@simondotm/nx-firebase

MIT License

175 stars 31 forks source link

v2.1.0 release issues #151

Closed simondotm closed 9 months ago

simondotm commented 9 months ago

Heads up folks, there's a few issues with this release. Typical that the first time I released new features without beta tags, it has some problems :D

[x] getconfig target not being migrated properly
[x] .secret.local not being created in migrate
[x] assets glob is being quoted wierdly in the project.json
[x] functions build is not copying the env vars as it should, not sure why because it passes in e2e tests, ~~possibly due to above glob~~ - due to incorrect path being set
[x] serve executor not running as somehow I've managed to leave a @nrwl/devkit import in instead of @nx/devkit

Will try to address these in 2.1.1 patch very soon

pikilon commented 9 months ago

Hey Simon I am working with nx version 16.8.1 and I had a problem that I fixed in the end. Steps to reproduce

nx version 16.8.1
Install "@simondotm/nx-firebase": "^2.1.0"
Create a functions firebase app with your extension
package.json got modified with "esbuild": "^0.17.17"

Current behaviour You can't run npm install any longer for a conflict between esbuild and "@nx/esbuild": "16.8.1",

My fix In my case I have to change the version of "esbuild": "^0.17.17" to "esbuild": "^0.19.2"

If I removed esbuild = no more compilations of the functions

I hope it could help the next one.

Than you for your work @simondotm !!

simondotm commented 9 months ago

@pikilon - I removed @nx/esbuild in this commit as a package dependency, maybe that will fix it? 🤔

v2.1.1 has been released.

pikilon commented 9 months ago

@pikilon - I removed @nx/esbuild in this commit as a package dependency, maybe that will fix it? 🤔

v2.1.1 has been released.

I have updated but functions will not compile without the library npx nx deploy firebase-functions 👇

>  NX   Cannot find module 'esbuild'

simondotm commented 9 months ago

@pikilon hmm, it's pretty strange this error.

what's supposed to happen is that the @simondotm/nx-firebase:init generator declares which Nx packages it needs (of which @nx/esbuild is one) and they should then be installed to package.json when the plugin is first run.

(the plugin package itself does not need esbuild as a dependency or peerdep)

installing @nx/esbuild should then run its initialiser which will also add esbuild as a dev dependency to package.json

in the e2e tests I have for the plugin (using Nx 16.6.0), this is working as expected:

I'm wondering if this is an Nx issue? Some peer dep not being set properly maybe... so you get v0.17.17 instead of 0.19.2... 🤔

I can try updating to 16.8.1 and see if the e2e tests pass

simondotm commented 9 months ago

Ok I see the same issue in my e2e test for Nx 16.8.1

simondotm commented 9 months ago

I just tried updating to Nx 16.9.0 and 16.9.1 but they seem to completely break my workspace with dependency conflict errors 😞 gonna take a bit of investigation I think

simondotm commented 9 months ago

I think that your fix of manually changing the esbuild dependency is going to be necessary until this is figured out