simondotm / nx-firebase

Firebase plugin for Nx Monorepos
https://www.npmjs.com/package/@simondotm/nx-firebase
MIT License
175 stars 31 forks source link

Add sourcemaps & emulator debugging support #166

Closed ciriousjoker closed 2 months ago

ciriousjoker commented 8 months ago

Caveat

  1. Debugger disconnects when saving files (because everything recompiles & emulators seem to restart).
  2. I didn't test this yet, I just added the flags where it made sense (adding them works in a real project though)
  3. I wrote no documentation for this for now
simondotm commented 7 months ago

This PR looks good, thanks for the contribution.

I've opened some discussion for this feature here: https://github.com/simondotm/nx-firebase/issues/165#issuecomment-1797046946

I'm going to hold this PR here for now, while I plan out what is needed in the next release, and if this feature can be included with all of the above.

ciriousjoker commented 7 months ago

I have no clue how to add the remaining stuff like e2e tests and schema migrations

dzivoing commented 5 months ago

Has this been merged ? I am trying to debug functions with no success

simondotm commented 2 months ago

I've moved tests around so I'll resolve the conflict/merge from master.

UPDATE: cant merge this as-is, because it is a commit to main branch. I'll try and re-target to a feature branch.

simondotm commented 2 months ago

@ciriousjoker I would like to merge your PR, but because it is merging commits directly to main I cannot accept it.

If you could please sync your fork with the latest from my repo, then re-create your changes on a separate PR branch on your fork and re-submit the PR I'll merge it, and you will keep the contribution credit for this change.

Alternatively, just let me know if you are busy, and I will make the changes here myself.

Thanks

ciriousjoker commented 2 months ago

@simondotm there you go