search

simondotm / nx-firebase

Firebase plugin for Nx Monorepos
https://www.npmjs.com/package/@simondotm/nx-firebase
MIT License
175 stars 31 forks source link

Cleanup of unneeded files? #189

Open jaytavares opened 4 months ago

jaytavares commented 4 months ago

After creating about 5 new functions projects and deleting the assets/ folder every time, I took a look in the src for this plugin to see if it would be an easy addition. To my surprise I found that the code already exists but is never called.

Is there a reason why it is never called?

simondotm commented 4 months ago

Wow! Great spot. Indeed, that code should be called but isn't. Ok let's get that fixed for the next release then 👍

simondotm commented 3 months ago

Looking into this again, I believe I left assets in the function node app, just in case anyone wanted to override environment vars per function. Not sure how useful that is tbh. 🤔