search

simondotm / nx-firebase

Firebase plugin for Nx Monorepos
https://www.npmjs.com/package/@simondotm/nx-firebase
MIT License
175 stars 31 forks source link

chore: Move @nx/node dependency to peer dependencies #190

Closed jaytavares closed 3 months ago

jaytavares commented 4 months ago

By making the @nx/node dependency a peer dependency, the function generator can generate projects that better match the given Nx workspace.

Fixes #191

jaytavares commented 3 months ago

@simondotm Any thoughts on this? We are on Nx@18 and this package is pulling in the deprecated @nrwl/linter@16 package. I think it's messing with our CI as a result.

simondotm commented 3 months ago

Hi @jaytavares thanks for this, I'll take a look at this over the weekend. šŸ‘ I had some similar work in progress, but will prioritise a release asap

jaytavares commented 3 months ago

Ah okay. Iā€™m in favor of removing it altogether if possible. šŸ‘

On Sunday, Mar 24, 2024 at 4:29 AM, Simon M @. @.)> wrote:

@simondotm commented on this pull request.

In packages/nx-firebase/package.json (https://github.com/simondotm/nx-firebase/pull/190#discussion_r1536765987):

@@ -22,10 +22,9 @@ "executors": "./executors.json", "peerDependencies": { @./devkit": ">= 16.1.1", + @./node": "^16.6.0",

I'm thinking this should be ">= 16.1.1" ?

Or even more ideally, remove it altogether. The plugin init generator already tries to ensure @@.*** is a workspace dependency when it runs.

ā€” Reply to this email directly, view it on GitHub (https://github.com/simondotm/nx-firebase/pull/190#pullrequestreview-1956502448), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAFNTV6UKRPZTZNIS2ZKUO3YZ2FHHAVCNFSM6AAAAABEA6XJZCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWGUYDENBUHA). You are receiving this because you were mentioned.Message ID: @.***>