search

simondotm / nx-firebase

Firebase plugin for Nx Monorepos
https://www.npmjs.com/package/@simondotm/nx-firebase
MIT License
175 stars 31 forks source link

Upgrade to NX Version 13 #45

Closed BraunreutherA closed 2 years ago

BraunreutherA commented 2 years ago

As this project doesn't work anymore with NX version 13, this PR changed the V12 createProjectGraph() function to await createProjectGraphAsync('4.0') which is backward compatible through the version number. This only fixes the existing problem with the newer NX version - still the plugin should be refactored to use the new projectGraph Version.

johngrimsey commented 2 years ago

@simondotm Keen for this one 👍

ghost commented 2 years ago

Hi @simondotm, is this PR going to be merged any time soon?

enchorb commented 2 years ago

@simondotm Would be great to get this merged so we can stop using the patch in prod

johngrimsey commented 2 years ago

Also, cheers @BraunreutherA 👏

ziolmar commented 2 years ago

+1

sk91 commented 2 years ago

+1

wojtiku commented 2 years ago

+1 for this, please :)

mati0090 commented 2 years ago

obraz

victorouse commented 2 years ago

+1

hs-wolf commented 2 years ago

Any news about @simondotm ?

Hadjimina commented 2 years ago

This would help me out a lot! Thanks for your work @simondotm.

simondotm commented 2 years ago

Hi all, apologies for not being on top of this. Please see my post here: https://github.com/simondotm/nx-firebase/issues/46

Thankyou all for your contributions and suggestions. I had no idea this repo was of such interest and I will do what I can to help it be managed by the community.

To expediate things I will bless this PR without any review since everyone above seems to like it, plus I've also invited BraunreutherA to be a collaborator to start opening this project up to the community.

Cheers Simon

romshiri commented 2 years ago

@simondotm Thanks, which version include the fix? When I try to download the latest version (0.3.3) I still get the error this PR suppose to fix.

simondotm commented 2 years ago

Hi folks I quickly tried to get a new release out last Friday but the GitHub action failed for some reason. I'm not at my computer now for a few days so the soonest I can look into it will be this weekend.

johngrimsey commented 1 year ago

This has been a very helpful lib for me and I'm grateful to @simondotm for his efforts.

At present I'm only running one set of Firebase Functions, and all my individual apps share the same Firebase project.

I've decided to remove this as a dependency from my project and have opted instead for a standard Nx Node app, things are much simpler now for me.