V15 rewrite

[simondotm]

Despite multiple attempts by contributors and myself, it was very difficult to cleanly retrofit the plugin to newer versions of Nx. So the whole plugin has been rewritten from scratch:

• Nx architecture and internal APIs have evolved significantly (for the better) since v12
• v15 introduces a cleaner approach to compilers - we now use the @nrwl/js:tsc plugin as a base
• Nx Plugin architecture is much easier to extend in v15, so there is far less copy/paste code
• Nx v15 supports JS async generators, which means we can now properly support --watch in the plugin
• Simpler solution, less code, less maintenance
• No more need for e2e patch shenanigans

This first step enables next steps & aims which are to support:

• The new Firebase SDK codebase feature
• Support multiple Firebase functions applications per codebase, so that deployments & dependencies can be better managed
• Support named Firebase projects as generator options rather than the default
• Support --watch on serve commands
• Sunset use of configs in favour of the Firebase function parameters
• Hopefully support ability to import web-packed libraries to functions, which should help reduce dependency concern where micro-libraries are created simply to minimize what's imported to a function to ensure faster cold starts.

[simondotm]

e2e tests failing for some reason I'm trying to figure out. Not working on my local either anymore.... Nx not picking up the imported buildable library dependency - latest version of Nx should detect this and auto-build it before trying to build the functions app.

[simondotm]

Ok so building before and after updating a source file changes the error (no deps detected), but 2nd build just used cached output from 1st build. So changes to source files in the e2e test in between are not being detected by Nx for some reason. Classic Nx experience.

[simondotm]

Fed up with this now, spent too much time on it. The e2e test workspace simply does not calculate dependencies properly. I'm getting various different errors:

• typescript 'not in rootDir' errors when adding an import to a buildable workspace library
• the project dep graph doesnt update properly when adding library dependencies, so even the firebase npm dependencies dont get output to the dist package.json
• the cached build is used even when a source file is modified - suggesting the input files being hashed are not correct
• turning off the daemon makes no difference
• adding @nrwl/js plugin config to force analyzeSourceFiles to true makes no difference (which is shouldnt anyway)
• sometimes running commands outside the e2e test with the daemon enabled does fix some of these, but I've no idea what the reason for that is
• maybe @nrwl/js:tsc executor doesnt like being used to build apps (it only has lib generator now)?
• The @nrwl/node:node executor is no use, nor is the @nrwl/node:webpack executor, as we just want to typescript compile our functions code. (which @nrwl/node:package used to do, but this has been removed from Nx)

My overall hunch is that these issues are all e2e workspace related, so lets see if the plugin works when installed in a real workspace.

[simondotm]

Oh and updating to v15.3.0 of Nx seems to mean that all generated tsconfig files have changed which doesn't give confidence that Nx is anywhere close to stable. I like Nx, but boy my experience is that it is persistently buggy and the amount of things that change between releases is wild.