simondotm / nx-firebase

Firebase plugin for Nx Monorepos
https://www.npmjs.com/package/@simondotm/nx-firebase
MIT License
180 stars 31 forks source link

Failed to deploy because of missing dependencies #77

Closed ciriousjoker closed 1 year ago

ciriousjoker commented 1 year ago

I have a package.json in the apps/myapp repo.

I had to add these dependencies there into the empty dependency section:

  "dependencies": {
    // this was empty before
    "axios": "^0.27.2",
    "countries-list": "^2.6.1",
    "randomstring": "^1.2.2"
    // ... <- here go most(!) of the dependencies I installed in the top level, but not all.
  },

All of these dependencies are already specified in the top level package.json.

Is this expected behavior or a bug? This previously worked (I was using a patched nx-firebase package though).

Some dependencies are copied into the dist/myapp/package.json file properly, for example "klaviyo-api", which is definitely not on some sort of whitelist.

simondotm commented 1 year ago

Thanks for reporting this @ciriousjoker I've seen some odd behaviour like this with my e2e tests, but I am aiming to have a new release of the plugin within the next week or so which I'm hoping will fix issues like this.

In the meantime, if you could let me know what version of Nx you are using that could be helpful.

ciriousjoker commented 1 year ago

Most of the nrwl packages are at either 15.0.0, some a couple patches higher. Can give full list if necessary

simondotm commented 1 year ago

Thanks, just that you are on Nx 15+ is useful. I'll post up here when the new plugin version is released, would be great to have someone try it.

simondotm commented 1 year ago

@ciriousjoker I am optimistic that this is no longer an issue with the 0.13.0-beta.0 of the plugin, with Nx 13.10.6+

simondotm commented 1 year ago

Closing for now. Can open a new issue if we see it happen again.