Silent Crash of application when we try to open a corrupt threatmodel diagram

[kalyancheerla]

Bug Report A silent crash of threats manager studio windows application when we try to open a corrupt threat model diagram i.e., when the parentID and ID of any entity or group is same. The application silently closes down leaving the .tmlock file when we press on diagram 1 to open.

To Reproduce Steps to reproduce the behavior:

1. Open the buggy.tm with TMS windows app.
2. Once the document is successfully loaded, press on the diagram 1.
3. App crashes silently
4. .tmlock file is left behind without cleanup and the it doesn't report any error.

Expected behavior Expecting the app at the very least to clean the tmlock file or report error and doesn't open the diagram for the corrupt threat model.

Screenshots ID and parentID were same,

Below zip file contains the buggy.tm TMS file, reqfiles_for_bug.zip

Additional context

[simonec73]

Thank you for the nice verification. I will fix this.

[kalyancheerla]

I am happy to help, if you could provide me with your thoughts on its implementation. Also, it would lessen your work and provide me with some open-source credits that I can boost-off about! 😄