simonedegiacomi / gphotosuploader

Unofficial Google Photos uploader and Go library
GNU General Public License v3.0
99 stars 29 forks source link

Timestamp is wrong #4

Closed nmrshll closed 6 years ago

nmrshll commented 6 years ago

Timestamp in the upload options is wrong, it should be multiplied by 1000.

At the moment in the library I'm just doing this to fix it :

options, err := api.NewUploadOptionsFromFile(file)
if err != nil {
    return err
}
options.Timestamp = options.Timestamp * 1000

But I guess this should be in the library directly.

Correct me if I'm wrong or if this works well in some cases but not for all files.

By the way, how can I contribute ? Just fork and create pull requests ? I quite like your project so far, and I can see a few ways I would like to change it.

simonedegiacomi commented 6 years ago

You're right, I didn't notice it because i was uploading images with metadata, so i agree that the timestamp should always be multiplied.

You can contribute forking and creating pull requests, thank you!

nmrshll commented 6 years ago

Here's a small PR, more coming