search

simonepri / country-iso

🗺 Get the ISO 3166-1 alpha-3 country code from geographic coordinates.
MIT License
144 stars 9 forks source link

Bir Tawil disputed area 21°52′9″N 33°44′52″E #8

Open tforward opened 6 years ago

tforward commented 6 years ago

Bir Tawil disputed area

Wiki - Bir Tawil

Currently Returns nothing should return "Terra Nullius"

simonepri commented 6 years ago

@tforward Thank You for the issue!!

When I was working on the map some months ago I've noticed these two holes of land: image image but I was unable to find information about them, so thank you for the video.

Anyway the package returns only countries that owns a country code. Here you can find the list of all official country codes released.

Any ideas on how we can include this non-official area?

tforward commented 6 years ago

Only thing I could think of is have if the ISO country code returns NULL and then if IS Sea also returns NULL then another function runs which compares the area to a exception set of polygons that have custom values for them. This is a pretty edge case scenario and there are many more weird boarders out there, and exclaves are another can of worms. Again pretty edge case but FYI

simonepri commented 6 years ago

I think it would be really interesting to list all these "weird boarders" in the Readme. We should also include all the disputed countries as a reference.

Are you interested in helping me?

tforward commented 6 years ago

I suppose.

Also, thinking about it a bit more it may be easier than I initially thought, however somewhat depends on the data you're using.

Are the holes in the data always these "Terra Nullius" areas?

If yes, then don't need to bother with the polygon intersects could just use the empty space!

If ISO country code is null and ISSea() is null return "Terra Nullius"

Kinda feels like an easter egg!