thetutlage commented 4 years ago

Since, Ava has received a major update, have to tweak the tests a little to get them passing.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@900c5ae). Click here to learn what that means. The diff coverage is 100.00%.

:exclamation: Current head d5dcd92 differs from pull request most recent head 4489a4a. Consider uploading reports for the commit 4489a4a to get more accurate results

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   98.83%           
=========================================
  Files             ?        1           
  Lines             ?       86           
  Branches          ?        0           
=========================================
  Hits              ?       85           
  Misses            ?        1           
  Partials          ?        0

Impacted Files	Coverage Δ
index.js	`98.83% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thetutlage commented 4 years ago

There seems to an issue with eslint-plugin-import that is making it fail on windows. https://github.com/benmosher/eslint-plugin-import/issues/1643

Apart from that the PR must be good to go. If required, I can squash commits to a single commit

simonepri / phc-argon2

Upgrade ava and argon2 versions #33

Codecov Report