search

simonepri / phc-argon2

🔒 Node.JS Argon2 password hashing algorithm following the PHC string format.
MIT License
17 stars 6 forks source link

Merge into argon2 #57

Open ranisalt opened 2 years ago

ranisalt commented 2 years ago

Hello! argon2 maintainer here. Since we adopted @phc/format a couple of years back, argon2 and @phc/argon2 have pretty much the same interface (argon2 exports a bit more stuff, but compatible). I was thinking @phg/argon2 should be merged into argon2, with argon2 adopting whatever is missing so that importing @phc/argon2 or argon2 is compatible. Then, you could just proxy the library (export * from 'argon2') and we would just have one library. What do you say?

simonepri commented 2 years ago

The phc-* project started as a way to provide a unified API for all the password hasing algoritmhs (mainly to build https://github.com/simonepri/upash).

I did not work on this for a long time now, so I'm unsure what's the state and how many people are using this packages (It seems almost none, https://www.npmjs.com/package/@phc/argon2).

As far as I remember, my idea was that say for argon2:

Just to help me understand this better, what's the benefit in merging?

ranisalt commented 1 year ago

Sorry for the massive delay, must have missed the notification

Just to help me understand this better, what's the benefit in merging?

Not much more than simplifying this package. argon2 and @phc/argon2 export the same functions and this will very likely not change, given that Argon2 and PHC format go hand in hand. It would also cover this:

In my view of things I immagined the two packages to be maintained by the same maintainer