search

simonepri / upash

🔒Unified API for password hashing algorithms
https://www.npmjs.com/upash
MIT License
536 stars 24 forks source link

Modified package to now use class based approach #10

Closed gavinhenderson closed 3 years ago

gavinhenderson commented 6 years ago

Here are the changes proposed in #9. They are by no means complete just wanted to get some opinions on the changes made so far before I put more time into tidying the code and adding more tests.

simonepri commented 6 years ago

Hi @gavinhenderson I'll review this asap. Thank you for the time you spent contributing!

gavinhenderson commented 6 years ago

@simonepri Thats those three changes made now. If you think these changes are okay let me know and I'll add more tests for the new API and I'll improve the way setting default works.

gavinhenderson commented 5 years ago

Hey @simonepri , just wondering if there was any more changes you wanted me to make 👍

simonepri commented 5 years ago

Hey @gavinhenderson sorry for the long delay, It looks cool. I'll dive into this during the weekend and I'll let know you know.

Thank you for contributing!

gavinhenderson commented 5 years ago

Hey @simonepri, I hope youre well! I noticed there hasn't been any changes on master for 4 months. Is there plans to mainain this project or should I close my pull request?

simonepri commented 5 years ago

@gavinhenderson No Gavin, I'm super happy with this PR. I'm working on a refactor for all the phc-* packages that upash relies on, and I want to finish it before merging this pr.

Sorry for the long delay.

indo-dev-0 commented 5 years ago

Updates on this? I would like to contribute changes that would benefit from a class based system.

gavinhenderson commented 5 years ago

@indo-dev-0 no updates from me

simonepri commented 5 years ago

Sorry for the 1-year long delay. (I had an intense year) I'll try to review and merge this before end of next week.