search

simongog / sdsl-lite

Succinct Data Structure Library 2.0
Other
2.21k stars 350 forks source link

install.sh should accept also a relative install path #19

Closed simongog closed 11 years ago

simongog commented 11 years ago

It should be possible to determine, if the given install path is relative and then translate it to the corresponding absolute path...

mpetri commented 11 years ago

readlink -f ../include

should do this.

simongog commented 11 years ago

not on my Mac and I think the file has to exist

simongog commented 11 years ago

have used pwd. Worked for me as expected. Can you guys also check?

tb38 commented 11 years ago

Works for me (on erde). However it fails, if directory doesn't exist. Any reasons why the script doesn't create the directory? I suggest in line 12 of install.sh (if -p works on mac os?) mkdir -p ${SDSL_INSTALL_PREFIX}

simongog commented 11 years ago

mkdir -p works on Mac OS. So go ahead ;)

mpetri commented 11 years ago

you will still have to check if mkdir -p worked (is it a proper path / do you have permissions to write to it)

tb38 commented 11 years ago

pls check.

tb38 commented 11 years ago

@mpetri Check is done by trying to enter directory