search

simonguest / quick-camera

Quick Camera is a MacOS utility to display, mirror, and rotate the output from any of your cameras
44 stars 20 forks source link

Resolution settings #12

Open rossbeazley opened 4 years ago

rossbeazley commented 4 years ago

Hi,

Love this app, I've modified it to always pick the highest resolution for the selected camera. I had one that defaulted to 640x480, yuk.

Would you be interested in a PR?

I thought it might be better if there was another menu option so a user could select from the supported resolutions, would this be if interest to you?

Let me know and I'll do it.

simonguest commented 4 years ago

That would be great, Ross - a sub menu with available resolutions from the camera would be a useful feature.

beazlr02 commented 4 years ago

So a quick play around to get something working locally and i can make a list like this

Screenshot 2020-09-18 at 12 28 04

Note ive differentiated different codecs the camera supports even though its technically the same res, im thinking we should just collapse down into a single resolution set as thats maybe a normal user might want?

Do you have any preferences?

PS i use this app several times a week at work for sharing whiteboard sessions and phone demos, its great!

Screenshot 2020-09-18 at 12 32 17

simonguest commented 4 years ago

Thanks for looking into this, Ross. What would you think about putting the resolution menu as a submenu of the camera source. Something like: 

Camera => Select Source => C922 Pro Stream Webcam => 640x480
                                                     720x480
                                                     800x600
                                                     1024x768
                                                     1600x1200 
                                                     1920x1080 ✔️

A check mark would indicate the selected resolution (with it defaulting to the highest resolution upon start). I also agree that we shouldn't show the codecs. (Also, selecting the camera name should still work as it does today.)

beazlr02 commented 4 years ago

sounds good to me, ill give that a go and submit a PR

beazlr02 commented 4 years ago

please see https://github.com/simonguest/quick-camera/pull/14

ajmas commented 3 years ago

BTW would it be worth having Quick Camera default to the highest resolution supported by the selected source device? I just realised I was capturing at half the resolution the device supported.