Any referenced schema in the model is always wrapped in an array

[LGLC]

Firstly, thanks for such a useful library! One issue I am having, though, is that the generated models are always wrapping any referenced objects in arrays (despite them not being listed as arrays in the swagger spec).

As an example, here is part of my swagger spec:

Article:
    required:
    - "id"
    - "queueItemId"
    - "title"
    - "standfirst"
    - "author"
    - "articleDate"
    - "lastUpdatedDate"
    - "path"
    properties:
      id:
        type: "integer"
      queueItemId:
        type: "integer"
      title:
        type: "string"
      makeModels: 
        type: "string"
      standfirst:
        type: "string"
      author:
        $ref: "#/definitions/Author"
      articleDate:
        type: "integer"
      lastUpdatedDate: 
        type: "integer"
      path: 
        type: "string" 
      pathId: 
        type: "string" 
      image:
        $ref: "#/definitions/Image"
      mainContent:
        $ref: "#/definitions/MainContent"
  MainContent:
    required:
    - "type"
    - "styleAttribute"
    type: "array"
    items: 
      type: "object"
    properties:
      type:
        type: "string"
      styleAttribute:
        type: "string"
      bodyText:
        type: "string"
      video:
        type: "string"
      image:
        $ref: "#/definitions/Image" 
      pullQuote:
        $ref: "#/definitions/PullQuote"
  Image:
    required:
    - src
    properties:
      src:
        type: "string"
      title:
        type: "string"
      alt:
        type: "string"
      caption:
        type: "string"

An Article contains an Image (not an array of Images). An Image itself is just an object. Yet if I look within the DB, I can see that the image field has been created as an array of Objects. You can see this in the JSON output below:

{
    "_id": "5a2678ac3aa3850f582f9deb",
    "id": 2,
    "relatedArticleId": 1,
    "queueItemId": 90,
    "title": "another article2",
    "makeModels": "string",
    "standfirst": "string",
    "articleDate": 0,
    "lastUpdatedDate": 0,
    "path": "string",
    "pathId": "string",
    "image": [{
        "src": "string",
        "title": "string",
        "alt": "string",
        "caption": "string",
        "_id": "5a2678ac3aa3850f582f9ded"
    }],

It's worth noting that there are some cases where there genuinely are arrays of objects, like the mainContent definition in swagger.

I had a little look and assumed it was the NOT circular reference part of processRef (that wraps the output in an array) that was causing the issue, but couldn't quite tweak it to get it working. Simply removing those brackets didn't work, nor did checking if they needed the array.

var processRef = function (property, objectName, props, key, required) {
  var refRegExp = /^#\/definitions\/(\w*)$/;
  var refString = property['$ref'] ? property['$ref'] : property['items']['$ref'];
  var propType = refString.match(refRegExp)[1];
  if (propType !== objectName) {
    // NOT circular reference
    props[key] = [getSchema(propType, definitions[propType]['properties'] ? definitions[propType]['properties'] : definitions[propType])];
  } else {
    // circular reference
    if (propType) {
      props[key] = {
        type: Schema.Types.ObjectId,
        ref: propType
      };
    }
  }
  fillRequired(props, key, required);
};

What I'm having to do at the moment is loop through the returned objects and re-flatten the properties correctly before they're turned into JSON, which obviously is a hacky way of doing it! Any help to avoid this would be much appreciated.

Thanks!

[LGLC]

I wrote a fix for this and was about to create a pull request, when I realised that it may already be fixed on the github repo. I'll check this tomorrow to confirm. If so, is there any chance you could update the version on npm?

[AxelGanter]

is it fixed?