search

simonh10 / python-edl

A python EDL parsing library
MIT License
90 stars 33 forks source link

Updated __init__.py to better handle default_fps #4

Closed Shootfast closed 10 years ago

Shootfast commented 10 years ago

Made default_fps value into a string (as required by the timecode library). Added None as the default argument for fps in Parser. Fixed init of Parser where fps was always set to the provided argument (including None).

Shootfast commented 10 years ago

Hi,

Just started using this library, and wanted to fix up the first little problems I noticed. At the moment, I am parsing EDL's where I don't care about the framerate, just the grading information in the comments. Also, the current version available in pip seems to be 0.1.8 (which I couldn't find tagged in this repo), but there is a commit titled 0.1.10? Any chance this pull request could be merged and made into a new version 0.1.11? The existing pip package also doesn't correctly express its dependency on pytimecode, but as that dependency is replaced by just "timecode" now, could that also be correctly expressed in the pip database?

Thanks!