search

simonhaenisch / md-to-pdf

Hackable CLI tool for converting Markdown files to PDF using Node.js and headless Chrome.
https://www.npmjs.com/md-to-pdf
MIT License
1.15k stars 110 forks source link

bug: #216

Closed austinlogo closed 1 year ago

austinlogo commented 1 year ago

Context: Warning display from Puppeteer

Describe the bug: More of a concern that Puppeteer is surfacing about their new api

Puppeteer old Headless deprecation warning:
    In the near feature `headless: true` will default to the new Headless mode
    for Chrome instead of the old Headless implementation. For more
    information, please see https://developer.chrome.com/articles/new-headless/.
    Consider opting in early by passing `headless: "new"` to `puppeteer.launch()`
    If you encounter any bugs, please report them to https://github.com/puppeteer/puppeteer/issues/new/choose.

A clear and concise description of what the bug is. Feel free to include screenshots.

image
simonhaenisch commented 1 year ago

Hey I don't expect this new headless mode will have any impact on the tool. If you want to get rid of the deprecation warning, you can downgrade your Puppeteer version for now (not sure which version they introduced this deprecation warning in though).

There's nothing to do here really, but if you want you can re-open and open a PR to refactor the tests to run with headless: "new".