search

simonhaenisch / md-to-pdf

Hackable CLI tool for converting Markdown files to PDF using Node.js and headless Chrome.
https://www.npmjs.com/md-to-pdf
MIT License
1.15k stars 110 forks source link

feature: embedded tweets #232

Closed invisiblegaudi closed 1 year ago

invisiblegaudi commented 1 year ago

Problem:

Related to #122

When outputting HTML, it is desirable to embed tweets rather than have a link to them taking the reader away from the page.

Solution:

I would like to have a flag e.g. --embed-socials to add the necessary HTML and js around the links to embed any urls to tweets

invisiblegaudi commented 1 year ago

willing to do the work for this

simonhaenisch commented 1 year ago

Closing as a duplicate of #233 because it's basically the same thing but just for a different social platform.

See https://github.com/simonhaenisch/md-to-pdf/issues/233#issuecomment-1657110930, imo best idea for it is to be solved with custom Marked extensions that can be published as npm packages, and we just need to make it easier to use those in md-to-pdf.