search

simonhaenisch / md-to-pdf

Hackable CLI tool for converting Markdown files to PDF using Node.js and headless Chrome.
https://www.npmjs.com/md-to-pdf
MIT License
1.15k stars 110 forks source link

Fix:Puppeteer reports a weird warning (#247) #248

Open thunderhunt opened 1 year ago

thunderhunt commented 1 year ago

Fixed the weird warning, and bumped up the puppeteer version.

simonhaenisch commented 1 year ago

I don't think this needs to be fixed... it's just a deprecation warning, the change in Puppeteer will have no actual impact on the output of md-to-pdf afaik.

thunderhunt commented 1 year ago

I don't think this needs to be fixed... it's just a deprecation warning, the change in Puppeteer will have no actual impact on the output of md-to-pdf afaik.

Agreed, but it give a big yellow warning , which may not be very comfortable for the users to see when they try out the tool. So thought to handle.

thunderhunt commented 12 months ago

@simonhaenisch Can we merge this PR? As It panics new users with that weird msg.

simonhaenisch commented 12 months ago

The headless: 'new' config change yeah we can merge but can you please verify that the --devtools flag still works (i.e. when you run md-to-pdf --devtools, it opens the browser, i.e. headful mode, with the rendered page, and opens dev tools).

The package.json and package-lock.json changes I don't want, please revert them.