search

simonhaenisch / rollup-plugin-typescript-paths

Rollup Plugin to automatically resolve path aliases set in the compilerOptions section of tsconfig.json.
https://npmjs.com/rollup-plugin-typescript-paths
MIT License
43 stars 12 forks source link

should strip comments from `tsconfig.json` before `JSON.parse()` #7

Closed beeplin closed 3 years ago

beeplin commented 3 years ago

tsconfig.json allows comments in JSON.

beeplin commented 3 years ago

can be simply done via https://github.com/sindresorhus/strip-json-comments

simonhaenisch commented 3 years ago

Thanks for the issue. Would be helpful if you were a bit more clear about the actual problem next time, like "this plugin breaks when I have a comment in my tsconfig ...". 🙃 I didn't go with your proposed solution because the TypeScript API has this built-in.