This PR contains a couple of superficial interface changes, as well as a bigger functional change.
2eb269e63180c49fd850f1a76f190df5f1fd40a0 adds some margin between button and input.
f8373017e58a72ace8aa407a025578f85cab3da9 adds page titles to the Vue components.
959f1d75d75ab38727ac80274f6a229d27ffda9d this was a tricky one: pre-selecting columns was not working for me and a JS error popped up in the console. I tracked this down to the array of fields not being an actual array, but an object with numeric keys. This change ensures it'll be a valid array.
347675c18eba1e4a390f3baf338d9c8ae5894a9e last but not least: this change fixes the mapping of columns in the Importer. Mapping happened in the model() method, but that method is not called until after validation, meaning the validation won't take advantage of your mapping. This causes the import to fail unless all columns in the CSV actually match the columns in your database. This change implements WithMapping to ensure the mapping is applied both for validation and for saving the models.
This PR contains a couple of superficial interface changes, as well as a bigger functional change.
Importer
. Mapping happened in themodel()
method, but that method is not called until after validation, meaning the validation won't take advantage of your mapping. This causes the import to fail unless all columns in the CSV actually match the columns in your database. This change implements WithMapping to ensure the mapping is applied both for validation and for saving the models.Let me know what you think!