search

simonhamp / laravel-nova-csv-import

The best CSV import component for Laravel Nova
https://novapackages.com/packages/simonhamp/laravel-nova-csv-import
MIT License
166 stars 76 forks source link

Added config option for canImportResource default value #43

Closed TheRealMkadmi closed 1 year ago

TheRealMkadmi commented 2 years ago

In a lot of cases, we'd have a large number of Resources with just a few of them "bulk importable". It's cumbersome to have to add $canImportResource = false in each request.

simonhamp commented 1 year ago

@TheRealMkadmi I think your issue is valid, but there's a lot of 'extra' stuff in this PR that doesn't appear to be related to solving that problem.

Please can you strip this back/split it up so that each set of changes is focussed on just one issue?

chihabhajji commented 1 year ago

LGTM!

simonhamp commented 1 year ago

@chihabhajji @MoetazBrayek that's not going to get this merged I'm afraid... needs more work