search

simonhamp / laravel-nova-csv-import

The best CSV import component for Laravel Nova
https://novapackages.com/packages/simonhamp/laravel-nova-csv-import
MIT License
168 stars 76 forks source link

Minor Fixes #51

Closed matt7ds closed 1 year ago

matt7ds commented 1 year ago

Two minor fixes - one for a bug on the Configuration page where a type error is created when saving "custom" Single Value field. The solution was to change this.values = "" to this.values = {} on the reset so the values are not typed to String

The second fix is the reference to config.map[key] in the review screen (to see errors/failed updates). This works when set to config.mappings[key]

ascepanovic commented 1 year ago

@matt7ds is in general import working for you, if so did u try it on resource with relations ?

kevin-dapps commented 1 year ago

What's remaining to get this PR merged into main? I'm currently experiencing this exact issue that these changes aim to fix.

Is there anything I can do to help? If not is there anyway I can add this patch to my project

kevin-dapps commented 1 year ago

@matt7ds just a heads up for anyone with the following option in their composer.json 

"config": {
        "optimize-autoloader": true,
        "preferred-install": "dist",

I had to run yarn install && yarn production on my forked repo before the changes were effective

simonhamp commented 1 year ago

@kevin-dapps have you tested this patch and been able to prove that it fixes your issues?

kevin-dapps commented 1 year ago

@simonhamp yes! I've tested these changes in my own forked repo and after generating the new dist folder it resolved my issues for the configure and review pages when using custom 'single value' 👍

simonhamp commented 1 year ago

@kevin-dapps awesome. I'll merge and release this then

kevin-dapps commented 1 year ago

Awesome, thanks a lot! Will this be v0.6.5 ? @simonhamp

simonhamp commented 1 year ago

@kevin-dapps it is - just released it today

kevin-dapps commented 1 year ago

@simonhamp thank you!

However since my composer.json file uses the flag "preferred-install": "dist", .....

I need you to update the dist folder in the github repository for the update to work for me. I was able to accomplish this on my forked repository by running yarn production which just runs the mix --production cmd and regenerates the js and css files.

sorry for the confusion and headache. 😅

simonhamp commented 1 year ago

Ah sorry, I thought I'd got the builds running on a GitHub Action...

I'll sort this out

simonhamp commented 1 year ago

@kevin-dapps done. Now on v0.6.6