search

simonihmig / ember-native-dom-helpers-codemod

Codemod to transform your jQuery based ember tests to use ember-native-dom-helpers
MIT License
27 stars 9 forks source link

Unwrap `andThen` when adding `await` #25

Closed scalvert closed 6 years ago

scalvert commented 6 years ago

Currently, when the codemod runs and adds await, it should ideally remove the use of andThen, as these things seem semantically incompatible.

@rwjblue

simonihmig commented 6 years ago

@scalvert it should actually do just that! If you take a look at the test fixtures for acceptance tests, this is the case. E.g. click.input.js and click.input.js.

Do you have an example where this is not working?

rwjblue commented 6 years ago

tldr; andThen(() => {}) was not being transformed. I submitted https://github.com/simonihmig/ember-native-dom-helpers-codemod/pull/26 to fix.

simonihmig commented 6 years ago

Released as 0.2.1! Thanks again!