search

simonihmig / ember-native-dom-helpers-codemod

Codemod to transform your jQuery based ember tests to use ember-native-dom-helpers
MIT License
27 stars 9 forks source link

jQuery `.html(string)` calls get erroneously transformed. #31

Closed scalvert closed 6 years ago

scalvert commented 6 years ago

When running the codemod, calls to

this.$('.foo').html('some string');

get erroneously transformed to

find('.foo').innerHTML;

Basically, this transform ends up lossy for .html() calls with parameters (when setting values).

simonihmig commented 6 years ago

@scalvert Thanks for reporting! Do you plan to fix this? I can do as well, just want to prevent accidentally doing the same work twice here...

scalvert commented 6 years ago

I can totally fix this. I just didn't get around to it yesterday. I'll work on it now.