search

simonihmig / ember-native-dom-helpers-codemod

Codemod to transform your jQuery based ember tests to use ember-native-dom-helpers
MIT License
27 stars 9 forks source link

Should use `triggerKeyEvent` instead of `keyEvent` #46

Closed wagenet closed 6 years ago

simonihmig commented 6 years ago

I don't see a triggerKeyEvent helper: https://github.com/cibernox/ember-native-dom-helpers#helpers.

In case you want to use the "offical" helpers from @ember/test-helpers, this is for you: https://github.com/simonihmig/ember-test-helpers-codemod

wagenet commented 6 years ago

Yes, I was confused by the similarity. What role does this repo have long term?

simonihmig commented 6 years ago

What role does this repo have long term?

Yes, so I think it will be superseded by the other, as e-n-d-h has also started to issue deprecation warnings, so this codemod can also be regarded as kind of deprecated. People might still want to use it, if they can't migrate to the new testing APIs right away.

I added a note to the Readme recently, that links to the other codemod.

wagenet commented 6 years ago

Thanks!