search

simonihmig / ember-stargate

Modern lightweight portals for Ember
MIT License
68 stars 12 forks source link

Require ember-resources v7 #687

Closed basz closed 3 months ago

basz commented 6 months ago

following these instructions I abstracted the class based resources of e-r 6 to those of ember-resource 7.

https://github.com/NullVoxPopuli/ember-resources/issues/1056

It works in the sense that all tests pass

cah-brian-gantzler commented 6 months ago

Fixes https://github.com/simonihmig/ember-stargate/issues/686

I had a PR as well but it would not let me submit it.

@simonihmig could we get this workflow run please. This is blocking me from updating ember concurrency V4 as ember-resources 6.x has a peer-dependency on ember-concurrency 3.x

basz commented 6 months ago

lint issues resolved

basz commented 5 months ago

uhg. lots of errors suddenly. I don't have time to dive into these atm...

cah-brian-gantzler commented 5 months ago

Did some experimentation. The first CI works which appears to be using ember 4.0 (and @types/ember_application 4.0.7). When trying other versions of ember, @types/ember_application 4.0.11 is being used which is where the errors are being generated. Appears to be mis-matched typescript types I guess. Hoping the little research I did helps, but very new to typescript and this is beyond my ability.

cah-brian-gantzler commented 5 months ago

Anyone able to take a look at this? It seems to be a problem of the types dependencies and not actually the code changes.

basz commented 5 months ago

Sorry atm no time to dive in

cah-brian-gantzler commented 4 months ago

Anyone have any chance in the foreseeable future? Have multiple addons that can not be updated as a result of this as addons are moving on to require ember-resources V7.

basz commented 3 months ago

@simonihmig I've updates some dependencies in the hope we will get a green light. could you rerun the pipeline?

simonihmig commented 3 months ago

@basz linting fails with some competing ember type definitions, and also in the yarn.lock you can see different versions of type packages being used. I think that could be solved by running npx yarn-deduplicate hopefully!

basz commented 3 months ago

👍 after some fiddling it run locally. Can't do the matrix somehow... lets see how this goes

simonihmig commented 3 months ago

There is some new ESLint error due to render-modifiers, probably due to new dependency versions?

But I wonder where did all the @types/ember__* packages go to, don't we need them?

basz commented 3 months ago

Saw the error. looking into how to avoid using ember-template-modifiers atm

I kept getting conflicts between types coming from @types/ember and @types/ember__*, so i just removed then to if that would resolve the conflicts. It did. All tests run fine except for the ember-template-modifiers. Let's see if I can fix that.

simonihmig commented 3 months ago

looking into how to avoid using ember-template-modifiers atm

I think we might want to just turn off the rule for now. I think we should migrate those to custom modifiers, but that seems well out of scope for this PR! :)

basz commented 3 months ago

pretty sure it run green aallll the way now... If you could do a release soon... it's my last unmet peer dependency thank you so much!

cah-brian-gantzler commented 3 months ago

Thank you for completing this. Its blocking some updates for me as well.

simonihmig commented 3 months ago

Thanks again for working on this @basz!

I think the requirement for a new major version of ember-resources, which many apps and addons also directly depend on, needs to be seen as a breaking change, so also require a new "major" from this addon. This is on 0.5, so that would be 0.6 (kinda indicating a breaking change), but that's no big deal.

I would like to also add some other breaking changes, like dropping support for older Ember versions. At this point 4.12 to start with seems reasonable? Or does anyone of you here have concerns with that? @basz @cah-brian-gantzler

(btw, it's not that we actively prevent those versions from working, just removing from the test matrix and not committing for support anymore)

cah-brian-gantzler commented 3 months ago

I am fine with all that. I agree with the breaking change. Technically any change to a 0.x is considered a possible breaking change. It is not until 1.x that changes to x should not be a breaking change.

basz commented 3 months ago

sounds good to me.

basz commented 3 months ago

hi @simonihmig

What are the other BC you propose and can we help with those?

simonihmig commented 3 months ago

Just dropping support for older Ember versions I think. Quickly raised this, if you want to have a look: #696

simonihmig commented 3 months ago

Released as v0.6.0: https://github.com/simonihmig/ember-stargate/releases/tag/v0.6.0

basz commented 3 months ago

Thank you!