search

simonihmig / ember-stargate

Modern lightweight portals for Ember
MIT License
68 stars 12 forks source link

Update ember-resources to 7.0.0 #688

Open bgantzler opened 4 months ago

bgantzler commented 4 months ago

This is the bare minimum to get to ember-resources 7.0.0 following the migration guide.

While the one by basz is better (does not require the migrated addon provided by nullvoxpopuli) that PR has stalled. Hoping that this one will not have the same issues.

bgantzler commented 4 months ago

@simonihmig if you were able to kick off the workflow and see if this has the same issues are the other PR would be appreciated

simonihmig commented 4 months ago

Done! Thanks for looking into this!

bgantzler commented 4 months ago

Will update the PR. I have been getting this 

Property 'controller' must be of type 'Registry', but here has type 'Registry'.

In my own code, there must be a update to the linter. This code is exactly like it is in the blueprints but throwing this error. Everywhere I have saw it it was suggested to disable the linter for those lines.

If anyone knows a better solution please let me know

cah-brian-gantzler commented 4 months ago

This seems to be a problem with the dependencies on definitively typed types. When the --no-lockfile option is used in the yarn install, this error occurs. Something has been updated in the definitely typed types that is incorrect. This error also occurs on the master branch.

The error is occurring when the following command is running glint --declaration.

Is it possible to not do the ember-try senarios temporarily until this is fixed? Or perhaps skip the glint declarations?