simoninns / DomesdayDuplicator

High-speed LaserDisc RF sampler
GNU General Public License v3.0
148 stars 21 forks source link

Improvements to the amplitude display #135

Closed atsampson closed 1 year ago

atsampson commented 1 year ago

Various work on @TokugawaHeavyIndustries's new amplitude display code - mostly to improve the performance, both by moving work out of the realtime capture thread and by simplifying the stats calculations. See the individual commits for more details.

This removes the code that was using QtMultimedia, so it works on Qt 5 again. Note that the first stanza in the CI config also tests the oldest version of Ubuntu we support - if we do remove Qt 5 support in the future (which we shouldn't do for a while - Qt 6 is still pretty new), this should be kept but switched to Qt 6.

There are still some oddities in the GUI that need addressing - the default window size is wrong, and the configuration window could do with being a proper layout rather than using absolute positioning.

Given what the FM signals DDD works with look like, it might be worth capping the number of samples the amplitude code looks at - it doesn't really need to analyse a full disk buffer's worth each time to get a good idea of the amplitude.

This also includes the CMake fixes that were in #131.