example_01 error

[matkuki]

Hi,

Trying to compile example_01_basic_app.nim and get:

...\.nimble\pkgs\nigui-0.1.0\nigui.nim(951, 41) Error: type mismatch: got <char>
but expected one of:
proc toUpper(c: Rune): Rune
proc toUpper(s: string): string

expression: toUpper(cast[char](unicode))

My specs:

• Windows 10 x64
• Nim Compiler Version 0.18.1 [Windows: i386]

[matkuki]

Changed line 951 in nigui.nim from return cast[int](cast[char](unicode).toUpper) to return cast[int](cast[Rune](unicode).toUpper) and commented out line 66 in nigui/private/windows/platform_impl.nim and it works. Seems like the problem is the recent string implementation change in the compiler.

[simonkrauter]

@matkuki Thx for reporting :)

[matkuki]

@trustable-code Line 66 still needs to be removed! https://github.com/trustable-code/NiGui/blob/master/src/nigui/private/windows/platform_impl.nim#L66

[simonkrauter]

@matkuki Why? I think it's necessary to end the string with two null bytes.

MultiByteToWideChar does not null-terminate an output string... https://msdn.microsoft.com/en-us/library/windows/desktop/dd319072(v=vs.85).aspx

[matkuki]

@trustable-code With line 66 uncommented the compilation succeeds, but running the executable throws: commenting out that line makes it work: Hope it helps.

[simonkrauter]

@matkuki : I have removed the line, thanks for trying out with latest Nim. Next time please open a new issue.

[matkuki]

@trustable-code Great, thanks! Will open a new issue next time 👍