search

simonlast / node-persist

Super-easy persistent data structures in Node.js
MIT License
719 stars 78 forks source link

Some readme fixes #119

Closed adriaandotcom closed 4 years ago

adriaandotcom commented 5 years ago

Thanks for this module. I really love it, coming from front end development.

adriaandotcom commented 5 years ago

cc @simonlast

akhoury commented 5 years ago

@adriaanvanrossum I'm also a maintainer of this module, would you mind replying to the review comments I added

adriaandotcom commented 5 years ago

I don't see any?

adriaandotcom commented 5 years ago

Ping @akhoury

adriaandotcom commented 5 years ago
akhoury commented 5 years ago

for some reason my comments are "pending"? not sure why, @simonlast ?

Anyways, here are screenshots of them.

comment-1

Screen Shot 2019-08-04 at 5 37 50 PM

comment-2

Screen Shot 2019-08-04 at 5 38 03 PM

adriaandotcom commented 5 years ago

Ah, I see. No worries! If your review is pending you need to submit your review.

Here is explained how you can do this: https://help.github.com/en/articles/reviewing-proposed-changes-in-a-pull-request#submitting-your-review

adriaandotcom commented 4 years ago

Too late.