(Merge) Sell pages

[ulternate]

• Added simple phone number validation (like super simple, it basically grabs the last 8-9 digits as they are the only valid numbers for landlines and mobiles in australia).
• This is done before save and will send an error if wrong (without updating).
• Fixed some odd coffee script stuff like the dashboard settings button hide/visible code as the button wasn't working if you linked to the page from dashboard/activity (i.e. started at dashboard/activity then clicked /settings tab would mean the code didn't fire until you edited the button, i.e. it wasn't hidden by default)
• Tweaked contact form validation prompt
• Deleted the methods from dashboard_controller.rb that aren't used and aren't necessary for the favourites tabs
• Moved contact_number and company_name fields in dashboard settings into one row on desktops and above email to condense and order the form (also removed required tag/class from them as they aren't required)
• Changed database storage from integer to string (this was the fix for issue #253 that was recently reported, an integer is 1-9 no 01-9 so 012345 as an integer is 12345. varchar database type fixed this, but to do that I needed to add some validation so we don't get non numbers in there)

^ Simon, i don't know how the last one affects prod. I did it using rake db:schema:dump rather than making a migration. Sorry if that stuffs things up for you. I'm hoping it's not an issue as you'll override the schema file on the prod server when you pull from master there.

Cheers,

Daniel

[jayden2]

@ulternate what if the phone number is inputted as +61 012 345 678?

[ulternate]

For the time being I'm only making sure you're not going to break the database when you try and save. So I'm only checking for a number.

We'd be better off using a gem for this as there's a bunch of things to test for and we might want to support area codes on landlines as well (I.e. (08) 9400 1234).

For the time being it will notify the user that they need to enter their number as 0412345678 or 94001234

Feel free to add more checking, but I'd say it's not important.

Feel free to display it however you like though. It'll be a nice and dependable value for any js you need to write

[jayden2]

Ok this is fine esp. for V1