Allow disabling hashable dependency

simonmar / async

Run IO operations asynchronously and wait for their results

BSD 3-Clause "New" or "Revised" License

323 stars 65 forks source link

Allow disabling hashable dependency #155

Closed 414owen closed 10 months ago

414owen commented 10 months ago

This allows people to disable the Hashable instance, and dependency. To keep compatibility, it's implemented as a flag that defaults to true. I think that if async were to release a new major version, it would be good to implement this as a sublibrary instead.

simonmar commented 10 months ago

What's the rationale for this?

414owen commented 10 months ago

I have a project that I'm keeping quite lean, and at the moment async is one of the two dependencies that depends on hashable.

In general, minimizing dependency footprints gives us some small wins:

Faster (first-time) compile times (eg in CI)
Faster link times
Smaller binary sizes
Easier ghc upgrades (almost certainly not an issue with hashable)

Admittedly I might be scraping the bottom of the barrel trying to get rid of hashable... Feel free to close this.

simonmar commented 10 months ago

This seems to me a very narrow use case and not worth adding conditional compilation for. If there's a lot of demand then I'll reconsider. Closing for now.