greenkeeper[bot]
commented
7 years ago Version 12.0.0 just got published.
Your tests are still failing with this version. Compare the changes 🚨
Release Notes
Better Map Set equalityMap/Set/WeakMap/WeakSet equality checks
User @BridgeAR pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks.
Typical example that was working before this release:
const m1 = new Map([[{ a: 1 }, 11]]);
const m2 = new Map([[{ a: 1 }, 11]]);
m1.should.be.eql(m2)And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example:
const m1 = new Map([[{}, 11], [{}, 12]]);
const m2 = new Map([[{}, 11], [{}, 12]]);
m1.should.be.eql(m2)This example is not that clear if it should assert or not, right? (it should).
As Map and Set (as their weak equavalents) allows to use any type value/ref as key, perfectly equal by value (what should.js do) {} and {} is not equal by reference. In should.js i am always trying to limit users to do not shoot themselfs in their foots and just do right thing if possible and when possible. That is why both examples will throw assertions starting 12.0.0.
Consistency in bundles
For the long time (probably several years now) browser bundle and node bundle has little differences in globals.
To make them sync i am doing such changes to bundles:
- Browser bundle will not contain
window.Shouldany more (with capital S). It was deprecated for the long time. Just usewindow.shouldas is. - Node bundle change
global.shouldto be should function instead of getter attached toObject.prototype.
Commits
The new version differs by 12 commits.
52dc121Release 12.0.06c1e6bdPrettier all6114e76Update years670df30Merge branch 'master' of github.com:shouldjs/should.jsecf8033Update toolse4d0accNormalize entry pointsf4adabbSet zuul to use 2 last versions of browsers8114b5dMerge pull request #143 from isayme/issue/aboveOrEqual-belowOrEqual02ec6a0fix error message for aboveOrEqual & belowOrEqual031888eMerge pull request #140 from carldunham/feature/cd/add-equals-eqls1e4909bAdd for readability: equals, eqls4a53d94Release 11.2.1
See the full diff
Version 11.2.1 of should just got published.
This version is covered by your current version range and after updating it in your project the build failed.
As should is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:
Status Details
- ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/simonmcmanus/url-builder/builds/209289768)Commits
The new version differs by 1 commits .
52b984fFix .match(RegExp) for everything not supportedSee the full diff.
Not sure how things should work exactly?
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).Your Greenkeeper Bot :palm_tree: