search

simonmeusel / MuteSpotifyAds

A efficent MacOS application automatically silencing ads of the spotify desktop app
GNU General Public License v3.0
436 stars 40 forks source link

Option to not start Spotifiy at start #21

Closed cfvescovo closed 5 years ago

cfvescovo commented 5 years ago

See issue #20 MuteSpotifyAds waits for Spotify to start. After Spotify is started MSA tracks songs and blocks ads. The checkbox to manage this setting doesn't work. (@simonmeusel Could you try to debug that?)

cfvescovo commented 5 years ago

Tomorrow I will resolve the conversations and I will make this draft ready for review. Goodnight!

simonmeusel commented 5 years ago

The auto-start like it was before wasn't working, because the if startSpotify {...} check was done in the constructor (init method) and at that point in time the config options weren't set. I have thus moved the logic to startWatchingForFileChanges()

simonmeusel commented 5 years ago

Released with v1.10.0: https://github.com/simonmeusel/MuteSpotifyAds/releases

cfvescovo commented 5 years ago

@simonmeusel Yeah, I thought that too but I didn't want to change the internal logic

cfvescovo commented 5 years ago

Thank you for your review!