simonmichael / hledger

Robust, fast, intuitive plain text accounting tool with CLI, TUI and web interfaces.
https://hledger.org
GNU General Public License v3.0
2.85k stars 307 forks source link

fix: roi correctly interacts with --value (fixes #2190) #2192

Closed adept closed 3 months ago

adept commented 3 months ago

roi was initially written when most of the --value / --cost infrastructure was either absent or in its infancy. As a result, roi attempted to do its own very ad-hoc "convert to a single cost" thing -- which is no longer needed, and in fact fails miserably sometimes, as shown by #2190 .

This hopefully makes roi interact with --value/--cost in a more straightforward way.